Re: slub: fix leak of 'name' in sysfs_slab_add

From: Dave Jones
Date: Fri Mar 07 2014 - 10:33:32 EST


On Fri, Mar 07, 2014 at 10:18:04AM +0400, Vladimir Davydov wrote:
> [adding Andrew to Cc]
>
> On 03/07/2014 01:11 AM, Dave Jones wrote:
> > The failure paths of sysfs_slab_add don't release the allocation of 'name'
> > made by create_unique_id() a few lines above the context of the diff below.
> > Create a common exit path to make it more obvious what needs freeing.
> >
> > Signed-off-by: Dave Jones <davej@xxxxxxxxxxxxxxxxx>
> >
>
> Since this function was modified in the mmotm tree, I would propose
> something like this on top of mmotm to avoid further merge conflicts:

Looks good to me.

thanks,

Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/