Re: [PATCH] tools/net/Makefile: Define PACKAGE to fix bfd build problems

From: David Miller
Date: Fri Mar 07 2014 - 13:10:00 EST


From: Markos Chandras <Markos.Chandras@xxxxxxxxxx>
Date: Fri, 7 Mar 2014 09:18:28 +0000

> On 03/06/2014 05:54 PM, David Miller wrote:
>> From: Markos Chandras <markos.chandras@xxxxxxxxxx>
>> Date: Thu, 6 Mar 2014 09:15:54 +0000
>>
>>> Fixes the following build problem with binutils-2.24
>>>
>>> gcc -Wall -O2 -c -o bpf_jit_disasm.o bpf_jit_disasm.c
>>> In file included from bpf_jit_disasm.c:25:0:
>>> /usr/include/bfd.h:35:2: error: #error config.h must be included
>>> before this header
>>> #error config.h must be included before this header
>>>
>>> This is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690
>>> "perf tools: bfd.h/libbfd detection fails with recent binutils"
>>>
>>> See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243
>>>
>>> CC: David S. Miller <davem@xxxxxxxxxxxxx>
>>> CC: Daniel Borkmann <dborkman@xxxxxxxxxx>
>>> Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx>
>>
>> I think your subject needs to be adjusted, this patch doesn't fix a
>> "bfd"
>> build problem.
>>
> Hi David,
>
> Thanks for the comment. Well it's problem caused by the bfd
> header. However, I suppose you can remove the 'bfd' word from the
> subject as I understand it's confusing. Would you be able to fix this
> before you apply this patch or should I send a new patch?

Please send a new patch, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/