Re: [PATCH v3 1/2] Staging: comedi: convert while loops to timeouts in

From: Chase Southwood
Date: Sat Mar 08 2014 - 22:56:06 EST


Hi Greg,

>On Saturday, March 8, 2014 9:00 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

>>On Fri, Mar 07, 2014 at 07:43:04PM -0600, Chase Southwood wrote:
>>This patch changes a handful of while loops to timeouts to prevent
>>infinite looping on hardware failure. A couple such loops are in a
>>function (s626_debi_transfer()) which is called from critical sections,
>>so comedi_timeout() is unusable for them, and an iterative timeout is
>>used instead. For the while loops in a context where comedi_timeout() is
>>allowed, a new callback function, s626_send_dac_eoc(), has been defined
>>to evaluate the conditions that the while loops are testing.  The new
>>callback employs a switch statement based on a simple new enum so that
>>it is usable for all of the different conditions tested in while loops
>>in s626_send_dac().  The proper comedi_timeout() calls are then used.
>
>Your subject seems to be missing a word at the end of it :(

Well what a silly problem to have :( I don't know what happened there
but I'll fix the subject and send it out again.

Thanks,
Chase
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/