Re: [PATCH v7 net-next 1/3] filter: add Extended BPF interpreter and converter

[Eric Dumazet]

On Sat, 2014-03-08 at 15:15 -0800, Alexei Starovoitov wrote:

> +/**
> + *	sk_run_filter_ext - run an extended filter
> + *	@ctx: buffer to run the filter on
> + *	@insn: filter to apply
> + *
> + * Decode and execute extended BPF instructions.
> + * @ctx is the data we are operating on.
> + * @filter is the array of filter instructions.
> + */
> +notrace u32 sk_run_filter_ext(void *ctx, const struct sock_filter_ext *insn)
> +{
> +	u64 stack[64];
> +	u64 regs[16];
> +	void *ptr;
> +	u64 tmp;
> +	int off;

Why is this 'notrace' ?

80 u64 on the stack, that is 640 bytes to run a filter ????


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/