Re: [Intel-gfx] [PATCH v3 1/1] drm/i915: Enabling 128x128 and 256x256 ARGB Cursor Support

From: Chris Wilson
Date: Mon Mar 10 2014 - 05:29:41 EST


On Sun, Mar 09, 2014 at 12:37:49AM +0530, Sagar Arun Kamble wrote:
> On Sun, 2014-03-09 at 00:34 +0530, Sagar Arun Kamble wrote:
> > On Sat, 2014-03-08 at 13:51 -0500, Alex Deucher wrote:
> > > On Sat, Mar 8, 2014 at 1:49 PM, <sagar.a.kamble@xxxxxxxxx> wrote:
> > > > From: Sagar Kamble <sagar.a.kamble@xxxxxxxxx>
> > > >
> > > > With this patch we allow larger cursor planes of sizes 128x128
> > > > and 256x256.
> > > >
> > > > v2: Added more precise check on size while setting cursor plane.
> > > >
> > > > v3: Changes related to restructuring cursor size restrictions
> > > > and DRM_DEBUG usage.
> > > >
> > >
> > > I'm not sure how useful it is since you appear to be able to
> > > selectively adjust the cursor size, but I recently added support for
> > > exposing the cursor size as a drm cap:
> > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=8716ed4e7bed4e4c7e3f37940e950ddc0362f450
> > >
> > > Alex
> > Thanks Alex. This is useful for cursor test to enumerate sub-tests based
> > on these caps.
> Realized after sending mail that we just get to know current cursor
> width and height. Can we have capability that exposes all supported
> cursor sizes?

The cap exposes the max cursor size. Knowing our hardware we can infer
that pot sizes from 64 to max are supported, but it would be better if
we did expose that information through the cap as well.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/