Re: [PATCH v3 Resend 2/3] regulator: Add support for S2MPA01 regulator

[Sachin Kamat]

On 10 March 2014 16:09, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>> > >> >> Add support for S2MPA01 voltage and current regulator.
>> > >>
>> > >> >> +
>> > >> >> +struct s2mpa01_info {
>> > >> >> +     struct regulator_dev *rdev[S2MPA01_REGULATOR_MAX];
>> > >> >
>> > >> > Hi,
>> > >> >
>> > >> > It seems that s2mpa01_info->rdev is not used anywhere, except as return
>> > >> > value of devm_regulator_register. I think you can remove it completely.
>> > >>
>> > >> Yes. I will send a follow up patch for this.
>> > >
>> > > Let's not break things and fix them up later. Fix it in this patch.
>> >
>> > Nothing is broken in this patch. What is suggested is just a code cleanup.
>> > I did not want to disturb the existing patch set as it is already reviewed
>> > and ready for merging. Anyway I can re-spin with this suggested change.
>> >
>> > >
>> > >> > Beside that, can this driver be merged into existing s2mps11 regulator
>> > >> > driver?
>> > >>
>> > >> Haven't analyzed this yet. Will look into the possibility of consolidation
>> > >> later.
>> > >
>> > > As above. If consolidation is possible it should be take care of in
>> > > the first instance.
>> >
>> > I need to analyze and see if this is really possible and the extent of
>> > re-usability.
>> > If possible, this might take a while for me before I start
>> > implementing it. Considering
>> > that this patch set is now over 2 months old and consolidations do
>> > happen subsequently
>> > I request you to queue this patch set in its current form (with the
>> > above change if you
>> > deem it necessary to be part of current patch set).
>>
>> I think the suggestion above should be fixed-up.
>>
>> Whether to consider consolidation or not is Mark's decision.
>
> Oh, Mark (the maintainer) isn't on CC? I think this is a mistake.

Sorry for missing. Thanks for fixing, Lee.

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/