Re: [PATCH] RFC: WIP: sc16is7xx [v0.4]

[One Thousand Gnomes]

On Mon, 10 Mar 2014 07:50:12 -0400 (EDT)
Jon Ringle <jon@xxxxxxxxxx> wrote:

> 
> On Mon, 10 Mar 2014, Alexander Shiyan wrote:
> 
> > ÐÐÐÐÐÐÐÑÐÐÐ, 10 ÐÐÑÑÐ 2014, 2:26 -04:00 ÐÑ jon@xxxxxxxxxx:
> > > From: Jon Ringle <jringle@xxxxxxxxxxxxx>
> > ...
> > > +config SERIAL_SC16IS7XX
> > > +	tristate "SC16IS7xx RS485 serial support"
> > > +	  select SERIAL_CORE
> > > +	  default n
> > > +	  help
> > > +	  This selects support for SC16IS7xx for use as a RS485 serial port
> > 
> > Documentation says:
> > The SC16IS740/750/760 is a slave IÂC-bus/SPI interface to a single-channel
> > high performance UART.
> > ...
> > The SC16IS740/750/760 also provides additional advanced features such
> > as auto hardware and software flow control, automatic RS-485 support...
> > 
> > So why do you position this chip as RS485 only? Automatic direction for
> > RS485 is just a feature as an addition for standart UART.
> 
> You're right. This is just how we are using the chip in our board. Would a 
> configuration flag in platform_data make sense to use the auto rs485 
> direction?

We have interfaces for RS485 runtime configuration so it could be
extended to set a lot of parameters that way, but I think for now it
might not be a bad idea to support rs485 auto direction in/out/off in the
platform data.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/