Re: serial core: crash / race condition on unbind

From: Geert Uytterhoeven
Date: Tue Mar 11 2014 - 06:58:12 EST


Hi Peter,

On Tue, Mar 11, 2014 at 4:14 AM, Peter Hurley <peter@xxxxxxxxxxxxxxxxxx> wrote:
>>
>> [...]
>>
>> /*
>> * Indicate that there isn't a port here anymore.
>> */
>> uport->type = PORT_UNKNOWN;
>>
>> state->uart_port = NULL;
>
> How did this ever work?
>
> Detaching the ll driver from the tty port in this manner is not ok;
> as you already note, it blows up if consoles are still running.

No one unbinds serial drivers using serial_core, as all these drivers are
for fixed hardware?

Hot-pluggable usb-serial doesn't use serial_core.

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/