Re: [PATCH] pinctrl-baytrail: add function mux checking in gpio pin request

From: Mathias Nyman
Date: Tue Mar 11 2014 - 07:38:29 EST


On 03/11/2014 12:27 PM, Linus Walleij wrote:
On Thu, Mar 6, 2014 at 2:59 PM, Chew Chiau Ee <chiau.ee.chew@xxxxxxxxx> wrote:

From: Chew, Kean Ho <kean.ho.chew@xxxxxxxxx>

The requested gpio pin must has the func_pin_mux field set
to GPIO function by BIOS/FW in advanced. Else, the gpio pin
request would fail. This is to ensure that we do not expose
any gpio pins which shall be used for alternate functions,
for eg: wakeup pin, I/O interfaces for LPSS, etc.

Signed-off-by: Chew, Kean Ho <kean.ho.chew@xxxxxxxxx>
Signed-off-by: Chew, Chiau Ee <chiau.ee.chew@xxxxxxxxx>

Patch applied with Darren's ACK.

This confirms my suspicion that you will not be able to
hide the pin control interface side of this hardware forever. ;-)

Hate to admit it but so it seems :)


Mika/Mathias: any comments?

Patch looks fine

Acked-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>

-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/