Re: [PATCH] ARM: zynq: Add OCM driver

From: Olof Johansson
Date: Tue Mar 11 2014 - 18:35:17 EST


On Tue, Mar 11, 2014 at 3:13 PM, Sören Brinkmann
<soren.brinkmann@xxxxxxxxxx> wrote:
> On Tue, 2014-03-11 at 02:31PM -0700, Olof Johansson wrote:
>> Hi Michal,
>>
>> Sorry for the late review, I didn't notice the driver when it was
>> posted and I only saw it now with the pull request. Comments below.
>>
>>
>> On Mon, Jan 6, 2014 at 7:36 AM, Michal Simek <michal.simek@xxxxxxxxxx> wrote:
>> > The driver provide memory allocator which can
>> > be used by others drivers to allocate memory inside OCM.
>> > All location for 64kB blocks are supported
>> > and driver is trying to allocate the largest continuous
>> > block of memory.
>>
>> I don't think you explain what OCM is anywhere, what is it? Since
>> you're reusing the generic SRAM driver I'm suspecting it's related?
>
> It stands for 'On-Chip Memory'. For Zynq that is a RAM consisting of
> four 64k chunks that can be individually mapped to a high or low address.

Ok, yeah, then it definitely should share drivers as much as possible
with the other vendors.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/