Re: [PATCH v2 2/3] spi/xtensa-xtfpga: add DT binding documentation

[Max Filippov]

On Wed, Mar 12, 2014 at 7:13 PM, Mark Rutland <mark.rutland@xxxxxxx> wrote:
> On Wed, Mar 12, 2014 at 12:21:04PM +0000, Max Filippov wrote:
>> Signed-off-by: Max Filippov <jcmvbkbc@xxxxxxxxx>
>> ---
>>  Documentation/devicetree/bindings/spi/spi-xtensa-xtfpga.txt | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/spi/spi-xtensa-xtfpga.txt
>>
>> diff --git a/Documentation/devicetree/bindings/spi/spi-xtensa-xtfpga.txt b/Documentation/devicetree/bindings/spi/spi-xtensa-xtfpga.txt
>> new file mode 100644
>> index 0000000..b6ebe2b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/spi/spi-xtensa-xtfpga.txt
>> @@ -0,0 +1,9 @@
>> +Cadence Xtensa XTFPGA platform SPI controller.
>> +
>> +This simple SPI master controller is built into xtfpga bitstreams and is used
>> +to control daughterboard audio codec.
>> +
>> +Required properties:
>> +- compatible: should be "cdns,xtfpga-spi".
>
> Is that the official name of the block? Nothing more specific?

There's no official name, so I composed this from the official name
of the platform + the block function. AFAIK there's single version of
this IP block. Marc G., please correct me if I'm wrong.

>> +- reg: physical base address of the controller and length of memory mapped
>> +  region.
>
> No interrupts?

Correct.

> Otherwise, this looks fine to me.

-- 
Thanks.
-- Max
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/