Re: [PATCH v3 1/2] Staging: comedi: addi-data: Fix long CamelCase function names

From: Ian Abbott
Date: Wed Mar 12 2014 - 13:49:08 EST


On 2014-03-12 01:06, Hartley Sweeten wrote:
On Tuesday, March 11, 2014 3:19 PM, Fred Akers wrote:
This patch fixes a few function names that are very long and are
not in the correct naming style

Signed-off-by: Fred Akers <knivey@xxxxxxxxxx>

Fred,

I pulled Greg's staging tree to see if your patches apply.

Patch 1/2 is ok but patch 2/2 does not apply:

Applying: Staging: Comedi: addi-data: Clean up function comments
error: patch failed: drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c:1
error: drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c: patch does not apply
error: patch failed: drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c:1
error: drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c: patch does not apply
error: patch failed: drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c:1
error: drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c: patch does not apply
Patch failed at 0001 Staging: Comedi: addi-data: Clean up function comments

Maybe Greg will have better luck.

Regards,
Hartley


FWIW, I managed to apply them, but mainly because our internal MS Exchange server (which often messes up patches) is down, so I'm having to deliver the mail to a "proper" mail server. :)

(Also, the patches in the driverdev-devel archive don't apply as-is, partly because it replaces '@' with ' at ', and partly because it replaces the ezsett character in 'Dieselstraße' with a question mark '?'.)

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/