Re: [PATCH v3 1/5] doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue

From: Roger Quadros
Date: Thu Mar 13 2014 - 08:17:50 EST


On 03/13/2014 01:41 PM, George Cherian wrote:
> On 3/13/2014 4:02 PM, Roger Quadros wrote:
>> Hi George,
>>
>> On 03/07/2014 01:56 PM, George Cherian wrote:
>>> Add the compatible "ti,am437x-dwc3" for dwc3 glue driver.
>>>
>>> Signed-off-by: George Cherian <george.cherian@xxxxxx>
>>> ---
>>> Documentation/devicetree/bindings/usb/omap-usb.txt | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt
>>> index 38b2fae..38d9bb8 100644
>>> --- a/Documentation/devicetree/bindings/usb/omap-usb.txt
>>> +++ b/Documentation/devicetree/bindings/usb/omap-usb.txt
>>> @@ -44,7 +44,9 @@ Board specific device node entry
>>> };
>>> OMAP DWC3 GLUE
>>> - - compatible : Should be "ti,dwc3"
>>> + - compatible : Should be
>>> + * "ti,dwc3" for OMAP5 and DRA7
>>> + * "ti,am437x-dwc3" for AM437x
>> Why do you need a new compatible for am437x? Isn't "ti,dwc3" sufficient?
>
> There is change in register offsets for AM437x as comapred to Omap5 and dra7x.
> The compatible is already added in dwc3-omap.c This patch just updates the Documentation.

Oh ok. Then it is fine. You can add my.

Acked-by: Roger Quadros <rogerq@xxxxxx>

cheers,
-roger
>>
>>> - ti,hwmods : Should be "usb_otg_ss"
>>> - reg : Address and length of the register set for the device.
>>> - interrupts : The irq number of this device that is used to interrupt the
>>>
>> cheers,
>> -roger
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/