Re: [PATCH] usb: gadget: fsl: Set dma_ops for FSL USB Gadget Device

From: Felipe Balbi
Date: Thu Mar 13 2014 - 11:29:19 EST


Hi,

On Thu, Mar 13, 2014 at 07:37:12PM +0530, Suresh Gupta wrote:
> From: Suresh Gupta <B42813@xxxxxxxxxxxxx>

return -ENOLOG

> Signed-off-by: Suresh Gupta <B42813@xxxxxxxxxxxxx>
> ---
> drivers/usb/gadget/fsl_udc_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c
> index 35b20e6..2a43d9d 100644
> --- a/drivers/usb/gadget/fsl_udc_core.c
> +++ b/drivers/usb/gadget/fsl_udc_core.c
> @@ -2456,6 +2456,7 @@ static int __init fsl_udc_probe(struct platform_device *pdev)
> /* Setup gadget.dev and register with kernel */
> dev_set_name(&udc_controller->gadget.dev, "gadget");
> udc_controller->gadget.dev.of_node = pdev->dev.of_node;
> + set_dma_ops(&udc_controller->gadget.dev, pdev->dev.archdata.dma_ops);

why is the driver doing this ? Why is the driver given knowledge about
details on archdata ?

Why do you need this at all ?

--
balbi

Attachment: signature.asc
Description: Digital signature