Re: linux-next: build failure after merge of the driver-core tree

From: Stephen Rothwell
Date: Mon Mar 17 2014 - 04:28:53 EST


Hi all,

On Wed, 12 Mar 2014 00:51:52 +0000 Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> After merging the driver-core tree, today's linux-next build ()
> failed like this on a PowerPC defconfig:
>
> HEAD is now at ceb98e684dec Merge remote-tracking branch 'driver-core/driver-core-next'
> GEN /home/broonie/next/powerpc_ppc64_defconfig/Makefile
> #
> # configuration written to .config
> #
> /home/broonie/next/next/arch/powerpc/platforms/powernv/opal-elog.c: In function 'elog_ack_store':
> /home/broonie/next/next/arch/powerpc/platforms/powernv/opal-elog.c:84:2: error: implicit declaration of function 'sysfs_schedule_callback' [-Werror=implicit-function-declaration]
> sysfs_schedule_callback(&elog_obj->kobj, delay_release_kobj,
> ^
> cc1: all warnings being treated as errors
> make[3]: *** [arch/powerpc/platforms/powernv/opal-elog.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> /home/broonie/next/next/arch/powerpc/platforms/powernv/opal-dump.c: In function 'dump_ack_store':
> /home/broonie/next/next/arch/powerpc/platforms/powernv/opal-dump.c:100:2: error: implicit declaration of function 'sysfs_schedule_callback' [-Werror=implicit-function-declaration]
> sysfs_schedule_callback(&dump_obj->kobj, delay_release_kobj,
> ^
> cc1: all warnings being treated as errors
>
> due to an interaction between d1ba277e7988908 (sysfs, driver-core: remove unused {sysfs|device}_schedule_callback_owner()) and 774fea1a38c6a5a8 (powerpc/powernv: Read OPAL error log and export it through sysfs) from the PowerPC tree.
>
> I reverted 774fea1a38c6a5a8 for today.

I instead reverted commit d1ba277e7988908 (sysfs, driver-core: remove
unused {sysfs|device}_schedule_callback_owner()). I hope that will work
as well.

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx

Attachment: pgphp9NiFwjAF.pgp
Description: PGP signature