Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

[boris brezillon]

Hello Mark,

Le 17/03/2014 11:02, Mark Rutland a écrit :
> On Mon, Mar 17, 2014 at 09:45:40AM +0000, Bo Shen wrote:
> > From: Boris BREZILLON <b.brezillon@xxxxxxxxxxx>
> >
> > Signed-off-by: Boris BREZILLON <b.brezillon@xxxxxxxxxxx>
> > Signed-off-by: Bo Shen <voice.shen@xxxxxxxxx>
> > ---
> >
> >   Documentation/devicetree/bindings/sound/atmel-wm8904.txt | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt
> > index 8bbe50c..aca341c 100644
> > --- a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt
> > +++ b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt
> > @@ -3,6 +3,8 @@ Atmel ASoC driver with wm8904 audio codec complex
> >   Required properties:
> >     - compatible: "atmel,asoc-wm8904"
> >     - atmel,model: The user-visible name of this sound complex.
> > +  - clocks: A list of clocks needed by the wm8904 chip.
> > +  - clock-output-names: Driver related clock names. Shall contain "pck0".
> The word "driver"  doesn't need to appear in biding documents, and this
> fails to describe what it sets out to. How about the following:
>
> - clocks: a list of phandle + clock-specifier pairs, one for each entry
>    in clock-names.
Agreed.
> - clock-names: Should contain "pck0"
After thinking a bit more about it, this can be any programmable clk (pckX).

I'll fix it.

Thanks.

Best Regards,

Boris

> Thanks,
> Mark.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/