Re: [PATCH 0/4] ata: add remaining new-style AHCI platform drivers

From: Hans de Goede
Date: Mon Mar 17 2014 - 15:19:33 EST


Hi,

On 03/17/2014 07:31 PM, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> This patch series adds new-style AHCI platform drivers for DaVinci DA850
> AHCI controller and ST SPEAr1340 AHCI controller. As a preparation for
> adding these drivers it also fixes ahci_platform_data->suspend() handling
> (patch #1) and moves library AHCI platform code to its own file (patch #2).
> The new AHCI platform drivers are only compile tested (they are marked as
> experimental because of this) and I would ask somebody with the hardware
> to verify them (thanks!).

Thanks for working on this.

Patches 1/2 seem sensible to me, and 3/4 are obviously a good idea. Also
all patches look good to me, so this series is:

Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans

>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
>
> Bartlomiej Zolnierkiewicz (4):
> ata: ahci_platform: fix ahci_platform_data->suspend method handling
> ata: move library code from ahci_platform.c to libahci_platform.c
> ata: add new-style AHCI platform driver for DaVinci DA850 AHCI
> controller
> ata: add new-style AHCI platform driver for ST SPEAr1340 AHCI
> controller
>
> drivers/ata/Kconfig | 23 +-
> drivers/ata/Makefile | 10 +-
> drivers/ata/ahci_da850.c | 178 ++++++++++++++
> drivers/ata/ahci_platform.c | 508 --------------------------------------
> drivers/ata/ahci_spear1340.c | 222 +++++++++++++++++
> drivers/ata/libahci_platform.c | 541 +++++++++++++++++++++++++++++++++++++++++
> 6 files changed, 967 insertions(+), 515 deletions(-)
> create mode 100644 drivers/ata/ahci_da850.c
> create mode 100644 drivers/ata/ahci_spear1340.c
> create mode 100644 drivers/ata/libahci_platform.c
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/