Re: [PATCH] mfd: as3722: make FUSE7_REG readable

From: Lee Jones
Date: Wed Mar 19 2014 - 13:04:55 EST


> > >> From: Stephen Warren <swarren@xxxxxxxxxx>
> > >>
> > >> The FUSE7_REG register is not currently marked readable. This causes
> > >> as3722_sd0_is_low_voltage() to emit an error during boot, and assume
> > >> the range of the SD0 regulator:
> > >>
> > >> as3722-regulator as3722-regulator: Reg 0xa7 read failed: -5
> > >>
> > >> Fixes: d4807ad2c4c0 ("regmap: Check readable regs in _regmap_read")
> > >> [exposed the bug, by checking for readability]
> > >> Fixes: 762a8ee80897 ("regulator: as3722: detect SD0 low-voltage mode")
> > >> [left out this register from the readable list]
> > >> Cc: Mark Brown <broonie@xxxxxxxxxx>
> > >> Cc: Michal Simek <michal.simek@xxxxxxxxxx>
> > >> Cc: Andrew Bresticker <abrestic@xxxxxxxxxxxx>
> > >> Cc: Vince Hsu <vinceh@xxxxxxxxxx>
> > >> Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx>
> > >> ---
> > >> Note: I believe the regmap commit mentioned above is for 3.15, whereas
> > >> the as3722 commit is in at least 3.14. So, this only needs to be applied
> > >> for 3.15, but might make sense to go into earlier kernels, at your
> > >> discretion.
> > >
> > > Applied to MFD -next (v3.15).
> >
> > I don't see this in next-20140319; did it get dropped somewhere, or was
> > your branch not pushed out?
>
> Ah, thanks for the reminder.
>
> I moved the MFD tree from linaro.org to kernel.org, but failed to let
> Stephen know. I'll do so now.

Whoops. No, you're Stephen. I meant Andrew.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/