Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

From: Jason Gunthorpe
Date: Wed Mar 19 2014 - 18:14:24 EST


On Wed, Mar 12, 2014 at 04:35:54PM -0500, Rob Herring wrote:

> > Florian, do you know what path to mainline a this patch should take?
>
> Via David's net tree.

Thanks

> > + cp = of_get_property(device, "compatible", &cplen);
> > + if (cp == NULL)
> > + return -EINVAL;
> > + while (cplen > 0) {
>
> This can all be:
>
> of_property_for_each_string(device, "compatible", prop, cp)

Done

On Thu, Mar 13, 2014 at 01:46:18AM +0300, Sergei Shtylyov wrote:
> The preferred multi-line comment style is:
>
> /*
> * bla
> * bla
> */
>

Sergei, the entire file use the 'net' multi-line commenting style, and
I have maintined that consistency with the new code.

v3 on its way.

Regards,
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/