Re: block: free q->flush_rq in blk_init_allocated_queue error paths.

[Jens Axboe]

On 03/19/2014 01:22 PM, Mike Snitzer wrote:
> On Wed, Mar 19 2014 at  3:12pm -0400,
> Dave Jones <davej@xxxxxxxxxx> wrote:
>
> > Commit 7982e90c3a ("block: fix q->flush_rq NULL pointer crash on dm-mpath flush")
> > moved an allocation to blk_init_allocated_queue(), but neglected to free
> > that allocation on the error paths that follow.
> >
> > Signed-off-by: Dave Jones <davej@xxxxxxxxxxxxxxxxx>
>
> Ngh.. thanks Dave!
>
> /me hangs his head in shame...
>
> Acked-by: Mike Snitzer <snitzer@xxxxxxxxxx>
>
> Jens, really sorry about this oversight.  I can take it on the chin and
> pick this up for Linus to take this week from linux-dm.git.  Your call.

No worries, I'll shove it off to Linus today. Then I can punch you on 
the chin next week.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/