Re: linux-next: build failure after merge of the akpm-current tree

From: Stephen Rothwell
Date: Mon Mar 24 2014 - 02:36:12 EST


Hi Andrew,

On Mon, 24 Mar 2014 17:23:27 +1100 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> After merging the akpm-current tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> In file included from include/linux/mm.h:897:0,
> from include/linux/mman.h:4,
> from arch/powerpc/kernel/asm-offsets.c:22:
> include/linux/vmstat.h: In function '__count_vm_event':
> include/linux/vmstat.h:36:2: error: implicit declaration of function 'raw_cpu_inc' [-Werror=implicit-function-declaration]
> raw_cpu_inc(vm_event_states.event[item]);
> ^
> include/linux/vmstat.h: In function '__count_vm_events':
> include/linux/vmstat.h:46:2: error: implicit declaration of function 'raw_cpu_add' [-Werror=implicit-function-declaration]
> raw_cpu_add(vm_event_states.event[item], delta);
> ^
>
> Caused by commit "vmstat: use raw_cpu_ops to avoid false positives on
> preemption checks".
>
> My kernel (even going back to v3.13) has no reference to
> raw_cpu_inc/add ... missed patch? Ah, ha percpu-add-raw_cpu_ops.patch
> etc are in the later part of the series :-(
>
> I just reverted "vmstat: use raw_cpu_ops to avoid false positives on
> preemption checks" and
> "vmstat-use-raw_cpu_ops-to-avoid-false-positives-on-preemption-checks-fix"
> for today.

I added them back at the end of the akpm tree (as part of the merge
commit, so you can't easily see them :-().

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx

Attachment: pgp4_R4XQGbB7.pgp
Description: PGP signature