Re: [PATCH] net/core: Use RCU_INIT_POINTER(x, NULL) in netpoll.c

[Eric Dumazet]

On Mon, 2014-03-24 at 07:11 -0400, Neil Horman wrote:
> On Mon, Mar 24, 2014 at 12:42:46AM +0530, Monam Agarwal wrote:
> > This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)
> > 
> > The rcu_assign_pointer() ensures that the initialization of a structure       
> > is carried out before storing a pointer to that structure. 
> > And in the case of the NULL pointer, there is no structure to initialize. 
> > So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)
> > 
> > Signed-off-by: Monam Agarwal <monamagarwal123@xxxxxxxxx>
> No, I don't think this is right. __netpoll_cleanup can be called in parallel
> with bottom half access to dev->npinfo.  rcu_assign pointer is safe against
> those accesses, but RCU_INIT_POINTER is not.

Wow, it is always safe for NULL value.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/