Re: [PATCH] ipv4: gre: Fix null pointer dereference in gre_cisco_err()

From: David Miller
Date: Mon Mar 24 2014 - 15:14:29 EST


From: Wei Zhang <asuka.com@xxxxxxx>
Date: Mon, 24 Mar 2014 15:34:31 +0800

> When use the gre vport, openvswitch register a gre_cisco_protocol but
> does not supply a err_handler with it. The gre_cisco_err() call the
> err_handler without existence check, cause the kernel crash.
>
> This patch base on v3.14-rc7. But the bug affect all kernel newer than
> 3.11!
>
> Signed-off-by: Wei Zhang <asuka.com@xxxxxxx>

Rather, openvswitch should provide an appropriate ->err_handler() that
returns PACKET_RCVD or PACKET_REJECT.

I'm not applying this patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/