Re: [PATCH] ipv4: gre: Fix null pointer dereference in gre_cisco_err()
From: wei zhang
Date: Tue Mar 25 2014 - 05:14:02 EST
AtÂ2014-03-25Â03:14:17,"DavidÂMiller"Â<davem@xxxxxxxxxxxxx>Âwrote:
>From:ÂWeiÂZhangÂ<asuka.com@xxxxxxx>
>Date:ÂMon,Â24ÂMarÂ2014Â15:34:31Â+0800
>
>>ÂWhenÂuseÂtheÂgreÂvport,ÂopenvswitchÂregisterÂaÂgre_cisco_protocolÂbut
>>ÂdoesÂnotÂsupplyÂaÂerr_handlerÂwithÂit.ÂTheÂgre_cisco_err()ÂcallÂthe
>>Âerr_handlerÂwithoutÂexistenceÂcheck,ÂcauseÂtheÂkernelÂcrash.
>>Â
>>ÂThisÂpatchÂbaseÂonÂv3.14-rc7.ÂButÂtheÂbugÂaffectÂallÂkernelÂnewerÂthan
>>Â3.11!
>>Â
>>ÂSigned-off-by:ÂWeiÂZhangÂ<asuka.com@xxxxxxx>
>
>Rather,ÂopenvswitchÂshouldÂprovideÂanÂappropriateÂ->err_handler()Âthat
>returnsÂPACKET_RCVDÂorÂPACKET_REJECT.
Thank you for your explanation, I misunderstand it .
I'm very sorry about this bothering!
>
>I'mÂnotÂapplyingÂthisÂpatch.