Re: [PATCH 2/7] atm: replace del_timer by del_timer_sync

From: Eric Dumazet
Date: Wed Mar 26 2014 - 17:57:08 EST


On Wed, 2014-03-26 at 22:33 +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@xxxxxxx>

>
> diff --git a/net/atm/mpc.c b/net/atm/mpc.c
> index b71ff6b..91dc58f 100644
> --- a/net/atm/mpc.c
> +++ b/net/atm/mpc.c
> @@ -1492,7 +1492,7 @@ static void __exit atm_mpoa_cleanup(void)
>
> mpc_proc_clean();
>
> - del_timer(&mpc_timer);
> + del_timer_sync(&mpc_timer);
> unregister_netdevice_notifier(&mpoa_notifier);
> deregister_atm_ioctl(&atm_ioctl_ops);
>

It seems this timer rearms itself, so this patch wont be enough I fear.




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/