RE: [PATCH v6] can: xilinx CAN controller support

[Appana Durga Kedareswara Rao]

Hi Joe perches,


> -----Original Message-----
> From: Joe Perches [mailto:joe@xxxxxxxxxxx]
> Sent: Wednesday, March 26, 2014 11:09 AM
> To: Appana Durga Kedareswara Rao
> Cc: wg@xxxxxxxxxxxxxx; mkl@xxxxxxxxxxxxxx; Michal Simek;
> grant.likely@xxxxxxxxxx; robh+dt@xxxxxxxxxx; linux-can@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Appana Durga
> Kedareswara Rao
> Subject: Re: [PATCH v6] can: xilinx CAN controller support
>
> On Wed, 2014-03-26 at 10:56 +0530, Kedareswara rao Appana wrote:
> > This patch adds xilinx CAN controller support.
> > This driver supports both ZYNQ CANPS and Soft IP AXI CAN controller.
>
> Just trivial notes about dmesg logging output.
>
> > diff --git a/drivers/net/can/xilinx_can.c
> > b/drivers/net/can/xilinx_can.c
> []
> > +static int set_reset_mode(struct net_device *ndev) {
> []
> > +                   netdev_warn(ndev, "timedout waiting for config
> mode\n");
>
> timed out
>
OK will do

> > +static int xcan_set_bittiming(struct net_device *ndev) {
> []
> > +   if (!is_config_mode) {
> > +           netdev_alert(ndev,
> > +                   "BUG! Cannot set bittiming can is notin config
> mode\n");
>
> "Cannot set bit timing - CAN is not in config mode\n"
>
> > +static int xcan_chip_start(struct net_device *ndev) {
>
> > +                   netdev_warn(ndev,
> > +                           "time out waiting for correct mode\n");
>
> Please be consistent.  Maybe
> "timed out waiting for correct mode\n"
>
Ok Will change.

> > +static int xcan_open(struct net_device *ndev) {
> > +   struct xcan_priv *priv = netdev_priv(ndev);
> > +   int ret;
> > +
> > +   ret = request_irq(ndev->irq, xcan_interrupt, priv->irq_flags,
> > +                   ndev->name, ndev);
> > +   if (ret < 0) {
> > +           netdev_err(ndev, "Irq allocation for CAN failed\n");
>
> irq is almost always lower case.
>
Ok Will change.

Regards,
Kedar.

>



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/