Re: [PATCH] x86: Fix the symbol versions on the 32-bit vDSO

From: Stefani Seibold
Date: Sun Mar 30 2014 - 02:35:00 EST


Am Samstag, den 29.03.2014, 13:15 -0700 schrieb Andy Lutomirski:
> The new symbols provide the same API as the 64-bit variants, so they
> should have the same symbol version name. This can't break
> userspace, since these symbols are new for 32-bit Linux.
>

This breaks my glibc patch... What is the benefit for doing this in that
way?

> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
> ---
> arch/x86/vdso/vdso32/vdso32.lds.S | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/vdso/vdso32/vdso32.lds.S b/arch/x86/vdso/vdso32/vdso32.lds.S
> index 28c4607..aadb8b9 100644
> --- a/arch/x86/vdso/vdso32/vdso32.lds.S
> +++ b/arch/x86/vdso/vdso32/vdso32.lds.S
> @@ -23,14 +23,18 @@ ENTRY(__kernel_vsyscall);
> */
> VERSION
> {
> + LINUX_2.6 {
> + global:
> + __vdso_clock_gettime;
> + __vdso_gettimeofday;
> + __vdso_time;
> + };
> +
> LINUX_2.5 {
> global:
> __kernel_vsyscall;
> __kernel_sigreturn;
> __kernel_rt_sigreturn;
> - __vdso_clock_gettime;
> - __vdso_gettimeofday;
> - __vdso_time;
> local: *;
> };
> }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/