[PATCH 3.2 187/200] net: fix 'ip rule' iif/oif device rename

From: Ben Hutchings
Date: Sun Mar 30 2014 - 19:29:10 EST


3.2.56-rc1 review patch. If anyone has any objections, please let me know.

------------------

From: Maciej Åenczykowski <maze@xxxxxxxxxx>

[ Upstream commit 946c032e5a53992ea45e062ecb08670ba39b99e3 ]

ip rules with iif/oif references do not update:
(detach/attach) across interface renames.

Signed-off-by: Maciej Åenczykowski <maze@xxxxxxxxxx>
CC: Willem de Bruijn <willemb@xxxxxxxxxx>
CC: Eric Dumazet <edumazet@xxxxxxxxxx>
CC: Chris Davis <chrismd@xxxxxxxxxx>
CC: Carlo Contavalli <ccontavalli@xxxxxxxxxx>

Google-Bug-Id: 12936021
Acked-by: Eric Dumazet <edumazet@xxxxxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
---
net/core/fib_rules.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c
index c0c21b1..6af54f2 100644
--- a/net/core/fib_rules.c
+++ b/net/core/fib_rules.c
@@ -718,6 +718,13 @@ static int fib_rules_event(struct notifier_block *this, unsigned long event,
attach_rules(&ops->rules_list, dev);
break;

+ case NETDEV_CHANGENAME:
+ list_for_each_entry(ops, &net->rules_ops, list) {
+ detach_rules(&ops->rules_list, dev);
+ attach_rules(&ops->rules_list, dev);
+ }
+ break;
+
case NETDEV_UNREGISTER:
list_for_each_entry(ops, &net->rules_ops, list)
detach_rules(&ops->rules_list, dev);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/