Re: [PATCH v2] lib: add size unit t/p/e to memparse

From: Duncan
Date: Tue Apr 01 2014 - 06:56:27 EST


Gui Hecheng posted on Tue, 01 Apr 2014 17:57:31 +0800 as excerpted:

> + * potentially suffixed with
> + * %K (for kibibytes, or 1024 bytes),
> + * %M (for mebibytes, or 1048576 bytes),
> + * %G (for gibibytes, or 1073741824),
> + * %T (for tebibytes, or 1099511627776),
> + * %P (for pebibytes, or 1125899906842624 bytes),
> + * %E (for exbibytes, or 1152921504606846976 bytes).

Why do the first two and the last two end in bytes, but the the middle
two don't? I'd suggest either only specifying bytes on the first one
(a reasonably common pattern in English, with the carry down to the
others implied) or on all of them.

--
Duncan - List replies preferred. No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master." Richard Stallman

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/