Re: [Jfs-discussion] [PATCH 1/1] fs/jfs/jfs_inode.c: atomically set inode->i_flags
From: Dave Kleikamp
Date: Wed Apr 02 2014 - 14:00:53 EST
On 04/02/2014 12:47 PM, Theodore Ts'o wrote:
> On Wed, Apr 02, 2014 at 07:29:50PM +0200, Fabian Frederick wrote:
>> + set_mask_bits(&inode->i_flags, S_IMMUTABLE | S_APPEND | S_NOATIME |
>> + S_DIRSYNC | S_SYNC, new_fl);
> Warning --- per discussion with Linus over the weekend, he decided he
> really didn't like the set_mask_bits() interface, because it was too
> prone to abuse. Unfortuantely, Linus had already included an earlier
> version of my patch that used set_mask_bits() in 3.14 without letting
> me know. This is what I have in my ext4 tree for the merge window,
> which is undergoing final testing at the moment. This will cause a
> patch conflict, and it's likely (given Linus's dislike of the
> set_mask_bits interface) that set_mask_bits() will end up getting
> removed from the tree, if not when he fixes up the merge conflict, but
> subsequent to -rc1.
Thanks Ted. I'll wait until the ext4 piece is resolved before merging
Fabian, feel free to resubmit the patch based on Ted's revision.
Otherwise, I'll fix it up myself.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/