Re: linux-next: Tree for Apr 1 (netfilter)

From: Geert Uytterhoeven
Date: Sun Apr 06 2014 - 12:09:52 EST

Hi David,

On Sun, Apr 6, 2014 at 5:31 PM, David Miller <davem@xxxxxxxxxxxxx> wrote:
>> On Tue, Apr 1, 2014 at 9:22 PM, David Miller <davem@xxxxxxxxxxxxx> wrote:
>>> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>>> Date: Tue, 01 Apr 2014 11:34:15 -0700
>>>> on x86_64:
>>>> net/netfilter/xt_connlimit.c: In function 'connlimit_mt_check':
>>>> net/netfilter/xt_connlimit.c:380:18: warning: division by zero [-Wdiv-by-zero]
>>>> Maybe just use CONNLIMIT_LOCK_SLOTS instead of ARRAY_SIZE(...).
>>> I'd rather see that ARRAY_SIZE() be adjusted to work cleanly for zero
>>> sized array elements.
>> Anyone with a suggestion?
>> Please note this is now in Linus' tree, possibly crashing people's boxes...
> I took in the version of the fix I didn't like via Pablo for
> now.

Thank you!

Fixing ARRAY_SIZE() can still be done later, if possible.



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvald
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at