Re: [PATCH v8 00/10] qspinlock: a 4-byte queue spinlock with PV support
From: Waiman Long
Date: Mon Apr 07 2014 - 12:38:49 EST
On 04/07/2014 02:14 AM, Raghavendra K T wrote:
I tested the v7,v8 of qspinlock with unfair config on kvm guest.
I was curious about unfair locks performance in undercommit cases.
(overcommit case is expected to perform well)
But I am seeing hang in overcommit cases. Gdb showed that many vcpus
are halted and there was no progress. Suspecting the problem /race with
halting, I removed the halt() part of kvm_hibernate(). I am yet to
take a closer look at the code on halt() related changes.
It seems like there may still be race conditions where the current code
is not handling correctly. I will look into that to see where the
problem is. BTW, what test do you use to produce the hang condition?
Patch series with that change gave around 20% improvement for dbench
2x and 30% improvement for ebizzy 2x cases. (1x has no significant
What is the baseline for the performance improvement? Is it without the
unfair lock and PV qspinlock?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/