Re: [visorchipset] invalid opcode: 0000 [#1] PREEMPT SMP

From: Greg Kroah-Hartman
Date: Mon Apr 07 2014 - 15:21:30 EST

On Mon, Apr 07, 2014 at 09:24:37AM -0500, Ken Cox wrote:
> On 04/07/2014 09:09 AM, Greg Kroah-Hartman wrote:
> >On Mon, Apr 07, 2014 at 07:17:25PM +0800, Fengguang Wu wrote:
> >>Hi Ken,
> >>
> >>I got the below dmesg and the first bad commit is
> >>
> >>git:// master
> >>
> >>commit 12e364b9f08aa335dc7716ce74113e834c993765
> >>Author: Ken Cox <jkc@xxxxxxxxxx>
> >>AuthorDate: Tue Mar 4 07:58:07 2014 -0600
> >>Commit: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> >>CommitDate: Tue Mar 4 16:58:21 2014 -0800
> >>
> >> staging: visorchipset driver to provide registration and other services
> >I think Sasha has already sent a fix to resolve this issue that I'll be
> >sending to Linus in a day or so.
> >
> >Ken, is Sasha's patch going to resolve this issue as well? It looks
> >like people haven't tested what happens when the module is loaded
> >without the hardware present in the system :(
> You are exactly right. The driver needs to check for hardware early on
> before trying to use it. Unfortunately, Sasha's patch will not resolve this
> one. I'll work with Ben Romer to get a patch out ASAP.

Wait, in looking at this closer, I don't see any of the "normal"
hardware checks to determine that this really is a valid piece of
hardware present, before it starts to just go and initialize a whole
bunch of things (sysfs busses, proc files and directories, and other

That's not ok, and it's obvious it's starting to affect people's work

How about I just mark the whole thing BROKEN for now, disabling the
build, until "correct" hardware probing can be added to the driver, so
no one else gets hurt by this?


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at