Re: [PATCH v2 4/5] Staging: rts5139: pr_warn(...) in place of printk(KERN_WARNING ...)

From: Greg KH
Date: Mon Apr 07 2014 - 16:54:42 EST


On Mon, Apr 07, 2014 at 01:34:47PM -0700, Joe Perches wrote:
> On Mon, 2014-04-07 at 22:27 +0200, Fabio Falzoi wrote:
> > All printk(KERN_WARNING ...) replaced with pr_warn(...).
>
> Please remove the RTS51X_TIP prefix and and and use
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> before any #include so that pr_<level> uses
> are prefixed in a standard way.


Feel free to do this as a follow-on patch, I'll take this one as-is, as
it is better than what we have currently...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/