Re: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer

[DaeSeok Youn]

Hi,

This patch didn't apply. Please check for me.
Thanks.
Daeseok Youn

2014-03-12 2:02 GMT+09:00 Jayamohan Kallickal <Jayamohan.Kallickal@xxxxxxxxxx>:
>
>
> -----Original Message-----
> From: Daeseok Youn [mailto:daeseok.youn@xxxxxxxxx]
> Sent: Thursday, February 20, 2014 5:13 PM
> To: JBottomley@xxxxxxxxxxxxx
> Cc: Jayamohan Kallickal; linux-scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer
>
> From b483ef302f7d77c586949ae170754d589e8a4935 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@xxxxxxxxx>
> Date: Fri, 21 Feb 2014 08:39:08 +0900
> Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer
>
> sparse says:
>
> drivers/scsi/be2iscsi/be_cmds.c:27:32: warning:
>  Using plain integer as NULL pointer
> drivers/scsi/be2iscsi/be_cmds.c:28:34: warning:
>  Using plain integer as NULL pointer
> drivers/scsi/be2iscsi/be_cmds.c:29:34: warning:
>  Using plain integer as NULL pointer
>
> Signed-off-by: Daeseok Youn <daeseok.youn@xxxxxxxxx>
> ---
>  drivers/scsi/be2iscsi/be_cmds.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c index 3338391..1ec9793 100644
> --- a/drivers/scsi/be2iscsi/be_cmds.c
> +++ b/drivers/scsi/be2iscsi/be_cmds.c
> @@ -24,9 +24,9 @@
>  int beiscsi_pci_soft_reset(struct beiscsi_hba *phba)  {
>         u32 sreset;
> -       u8 *pci_reset_offset = 0;
> -       u8 *pci_online0_offset = 0;
> -       u8 *pci_online1_offset = 0;
> +       u8 *pci_reset_offset = NULL;
> +       u8 *pci_online0_offset = NULL;
> +       u8 *pci_online1_offset = NULL;
>         u32 pconline0 = 0;
>         u32 pconline1 = 0;
>         u32 i;
> --
> 1.7.9.5
>
> Acked-By: Jayamohan Kallickal <jayamohan.kallickal@xxxxxxxxxx>
>
> --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/