Re: [PATCH v2] bus: mvebu-mbus: Avoid setting an undefined window size

From: Jason Gunthorpe
Date: Wed Apr 09 2014 - 12:31:28 EST


On Wed, Apr 09, 2014 at 09:53:50AM +0200, Thomas Petazzoni wrote:

> Maybe this is something that Jason can confirm/infirm. I remember
> having a quick look at the core Linux PCI core to see if it was
> somehow checking whether the bridge BAR has been properly configured,
> but I think I concluded it was not the case, and it was just assuming
> that write the memory base/limit in the bridge registers was
> sufficient.

I think the best way to fail would be to return an error from
mvebu_pcie_align_resource - but we can't create the window in that
call.

Once things get to the BAR write stage it shouldn't fail unfortunately.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/