Re: [PATCH] driver core: Move driver_data back to struct device

[Greg Kroah-Hartman]

On Thu, Apr 10, 2014 at 09:50:14AM +0200, Jean Delvare wrote:
> Hi Greg,
> 
> On Mon, 7 Apr 2014 13:58:15 -0700, Greg Kroah-Hartman wrote:
> > On Mon, Apr 07, 2014 at 10:53:22AM +0200, Jean Delvare wrote:
> > > Having to allocate memory as part of dev_set_drvdata() is a problem
> > > because that memory may never get freed if the device itself is not
> > > created. So move driver_data back to struct device.
> > > 
> > > This is a partial revert of commit b4028437.
> > > 
> > > Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > ---
> > > Greg, we discussed that back in January (in a thread named "Freeing of
> > > dev->p") but I did not hear back from you and I can't see this fix in
> > > your driver-core tree.
> > 
> > Thanks for doing this, I'll queue this up after -rc1 is out.  I still
> > have that thread in my TODO list, unfortunatly, higher-priority items
> > keep bumping it down :(
> 
> No problem, I understand.
> 
> Meanwhile I have prepared a patch set with all the cleanups that could
> go in after that one, basically reverting all of commit b4028437 step
> by step. If you want to take a look, it's at:
>   http://jdelvare.nerim.net/devel/linux-3/driver-core/
> 
> FWIW the full patch set shaves about 1.2 MB off an allmodconfig x86_64
> build. And it certainly comes with some performance gains too.
> 
> I can post the whole set now if you want, I just did not want to throw
> too much at you if you are already swamped.

Sure, please send them to me, my "swampedness" isn't an issue for
queueing up patches, it helps, as they will then have to be dealt with
in my queue :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/