Re: Oops in acpi_gpiochip_add on MacBookPro with Linux v3.14-12042-g69cd9eba3886

From: Linus Walleij
Date: Thu Apr 10 2014 - 14:47:43 EST


On Thu, Apr 10, 2014 at 2:40 PM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> On Thu, Apr 10, 2014 at 08:22:12AM -0400, Josh Boyer wrote:
>> On Thu, Apr 10, 2014 at 2:50 AM, RafaÅ MiÅecki <zajec5@xxxxxxxxx> wrote:
>> > 2014-04-09 23:09 GMT+02:00 Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx>:
>> >> With Linux v3.14-12042-g69cd9eba3886 I get an oops from the bcma
>> >> module on the MacBookPro 10,2 I have here. This works fine with Linux
>> >> v3.14-7333-g59ecc26004e7. There have been no changes between those
>> >> two versions to bcma itself, but the GPIO merge did go in that window.
>> >> I can attempt to do a bisect tomorrow, but looking over some of the
>> >> GPIO commits it seems pretty relevant to the ACPI GPIO changes. I'm
>> >> hoping someone here has an idea on what the issue might be and has
>> >> some possible things for me to test for fixes.
>> >
>> > Bug report: https://lkml.org/lkml/2014/3/24/262
>> > Patch: https://lkml.org/lkml/2014/3/24/293
>> > Tested by Sabrina: https://lkml.org/lkml/2014/3/24/304
>> > (all links are for the same thread).
>> >
>> > Now you simply have to find above patch in some git tree :) Not sure
>> > if it's already in Linus's one.
>>
>> Ah, wonderful. I now wish I would have found those in my searching
>> before doing the bisect. Oh well. For what it's worth, my bisect
>> landed on the same commit.
>>
>> The fix isn't in Linus' tree or linux-next. I'm guessing Mika is
>> either still on vacation, or hasn't sent out the formal fix yet.
>
> No, not on vacation anymore (unfortunately). I did send the formal patch
> already:
>
> https://lkml.org/lkml/2014/3/31/135
>
> but it isn't merged to Linus' GPIO tree yet.

I've queued this for fixes!

Will send upstream ASAP.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/