Re: [PATCH 1/5] sched: Convert thread_group_cputime() to use for_each_thread()

From: Peter Zijlstra
Date: Thu Apr 10 2014 - 14:57:08 EST


On Thu, Apr 10, 2014 at 06:19:55PM +0200, Peter Zijlstra wrote:
> On Wed, Apr 09, 2014 at 09:49:57PM +0200, Peter Zijlstra wrote:
> > Anyway, I'll look over the stuff tomorrow.
>
> That patch was missing useful clues..
>
> Also, I shot __for_each_thread in the head, it seemed useless.

Hmm, do we really want to have for_each_process_thread() ? Having people
explicitly write:

for_each_process(p) {
for_each_thread(p, t) {
}
}

isn't that much more effort and its a whole lot more explicit on the
double loop thing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/