Re: [PATCH] video: bf54x-lq043fb: fix build error

From: Tomi Valkeinen
Date: Mon Apr 14 2014 - 08:44:23 EST


On 12/04/14 04:30, Steven Miao wrote:
> From: Steven Miao <realmz6@xxxxxxxxx>
>
> should include linux/gpio.h
>
> Signed-off-by: Steven Miao <realmz6@xxxxxxxxx>
> ---
> drivers/video/bf54x-lq043fb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c
> index 42b8f9d..d2b54f1 100644
> --- a/drivers/video/bf54x-lq043fb.c
> +++ b/drivers/video/bf54x-lq043fb.c
> @@ -49,6 +49,7 @@
> #include <linux/spinlock.h>
> #include <linux/dma-mapping.h>
> #include <linux/platform_device.h>
> +#include <linux/gpio.h>

The driver includes <asm/gpio.h>. I think that should be removed, and
<linux/gpio.h> should be used.

Can you also remove the asm/gpio.h in your patch, and see if it compiles
fine?

Tomi


Attachment: signature.asc
Description: OpenPGP digital signature