[PATCH 10/38] tick-common: remove extra checks from tick_check_new_device()

From: Viresh Kumar
Date: Mon Apr 14 2014 - 12:25:41 EST


tick_check_new_device() is calling tick_check_percpu() which has this as the
first test:

if (!cpumask_test_cpu(cpu, newdev->cpumask))
return false;

And so the same isn't required to be repeated by tick_check_new_device(). Remove
it.

This also initializes several variables during their definition only.

Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
---
kernel/time/tick-common.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c
index 949f3d3..395cbbd 100644
--- a/kernel/time/tick-common.c
+++ b/kernel/time/tick-common.c
@@ -269,16 +269,9 @@ bool tick_check_replacement(struct clock_event_device *curdev,
*/
void tick_check_new_device(struct clock_event_device *newdev)
{
- struct clock_event_device *curdev;
- struct tick_device *td;
- int cpu;
-
- cpu = smp_processor_id();
- if (!cpumask_test_cpu(cpu, newdev->cpumask))
- goto out_bc;
-
- td = tick_get_device(cpu);
- curdev = td->evtdev;
+ int cpu = smp_processor_id();
+ struct tick_device *td = tick_get_device(cpu);
+ struct clock_event_device *curdev = td->evtdev;

/* cpu local device ? */
if (!tick_check_percpu(curdev, newdev, cpu))
--
1.7.12.rc2.18.g61b472e

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/