Re: [PATCH v3 00/03]: hwrng: an in-kernel rngd

From: Andy Lutomirski
Date: Mon Apr 14 2014 - 12:44:23 EST


On Mon, Apr 14, 2014 at 9:24 AM, Torsten Duwe <duwe@xxxxxx> wrote:
> On Mon, Apr 14, 2014 at 09:09:14AM -0700, H. Peter Anvin wrote:
>> I think the default should be zero, so each hwrng driver maintainer would have to consider what guarantees that particular driver can give. If anything 50% ought to be the maximum.
>
> Repost of v4 just for patch 03/03 is on its way then, defaulting to 0
> (off), which happens to be the old behaviour, which I think I've also
> expressed my sympathy for already.
>

To be clear, I like your patches, bikeshedding aside. Having reads of
/dev/random automatically pull in hwrng data would be *great*. My
drbg patches are not meant to replace them at all. I just think that
there's a need for the nonblocking pool to be well-seeded as quickly
as possible, regardless of configuration, and I don't think your code
is meant to do that.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/