Re: [PATCH] ASoC: fsl_sai: Fix incorrect condition check in trigger()

From: Mark Brown
Date: Mon Apr 14 2014 - 16:31:52 EST


On Fri, Apr 11, 2014 at 10:10:00PM +0800, Nicolin Chen wrote:

> + /* Check if the opposite FRDE is also disabled */
> + if (!(tx ? rcsr & FSL_SAI_CSR_FRDE : tcsr & FSL_SAI_CSR_FRDE)) {

I've applied this since it's a fix but this is *not* a triumph of
legibility, the ternery operator is often not helpful.

Attachment: signature.asc
Description: Digital signature