Re: [PATCH v3] MFD: driver for Atmel Microcontroller on iPaq h3xxx

From: Lee Jones
Date: Tue Apr 15 2014 - 06:27:08 EST


> This adds a driver for the Atmel Microcontroller found on the
> iPAQ h3xxx series. This device handles some keys, the
> touchscreen, and the battery monitoring.
>
> This is a port of a driver from handhelds.org 2.6.21 kernel,
> written by Alessandro Gardich based on Andrew Christians
> original HAL-driver. It has been heavily cleaned and
> converted to mfd-core by Dmitry Artamonow and rewritten
> again for the v3.x series kernels by Linus Walleij,
> bringing back some of the functionality lost from Andrew's
> original driver.
>
> Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
> Cc: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx>
> Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Alessandro Gardich <gremlin@xxxxxxxxxx>
> Signed-off-by: Dmitry Artamonow <mad_soft@xxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> ChangeLog v2->v3:
> - Pass a NULL parameter as suspend() function instead of
> passing a dummy implementation. The core won't call this
> anyway.
>
> Lee: if you're OK with this version please merge it for v3.16
> after v3.15-rc1...
> ---
> drivers/mfd/Kconfig | 10 +
> drivers/mfd/Makefile | 1 +
> drivers/mfd/ipaq-micro.c | 482 +++++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/ipaq-micro.h | 148 +++++++++++++
> 4 files changed, 641 insertions(+)
> create mode 100644 drivers/mfd/ipaq-micro.c
> create mode 100644 include/linux/mfd/ipaq-micro.h

Applied on trust that my previous comments have been addressed.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/