Re: [PATCH v2] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY

From: Felipe Balbi
Date: Wed Apr 16 2014 - 11:22:36 EST


On Wed, Apr 16, 2014 at 02:48:21PM +0300, Grygorii Strashko wrote:
> This fixes a regression on Keystone 2 platforms caused by patch
> 57303488cd37da58263e842de134dc65f7c626d5
> "usb: dwc3: adapt dwc3 core to use Generic PHY Framework" which adds
> optional support of generic phy in DWC3 core.
>
> On Keystone 2 platforms the USB is not working now because
> CONFIG_GENERIC_PHY isn't set and, as result, Generic PHY APIs stubs
> return -ENOSYS always. The log shows:
> dwc3 2690000.dwc3: failed to initialize core
> dwc3: probe of 2690000.dwc3 failed with error -38
>
> Hence, fix it by making NULL a valid phy reference in Generic PHY
> APIs stubs in the same way as it was done by the patch
> 04c2facad8fee66c981a51852806d8923336f362 "drivers: phy: Make NULL
> a valid phy reference".
>
> CC: Kishon Vijay Abraham I <kishon@xxxxxx>
> CC: Felipe Balbi <balbi@xxxxxx>
> CC: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>

I thought I'd already acked this one... oh well, need more coffee:

Acked-by: Felipe Balbi <balbi@xxxxxx>

--
balbi

Attachment: signature.asc
Description: Digital signature