Re: [PATCH 0/3] perf top/tui: Fixes for percentage filter behavior

From: Namhyung Kim
Date: Thu Apr 17 2014 - 09:38:39 EST


Hi Jiri,

2014-04-17 (ë), 14:00 +0200, Jiri Olsa:
> On Thu, Apr 17, 2014 at 04:53:23PM +0900, Namhyung Kim wrote:
> > Hi,
> >
> > This is a small fixes for a bug in perf top I found during some tests.
> > It gets segfault if symbol filter found no entries - accessing NULL
> > pointer in that case.
>
> yep, I hit that yesterday as well, but I ended up just with
> the patch below, your changes seems more comprehensive ;-)
> going to review..

Well, the end result will be same, but I think it should have 0
nr_entries when there's no entry to show.

Thanks,
Namhyung


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/