Re: [PATCH v2 1/4] sysctl: clean up char buffer arguments

From: Kees Cook
Date: Fri Apr 18 2014 - 02:24:26 EST


On Thu, Apr 17, 2014 at 5:28 PM, Andi Kleen <ak@xxxxxxxxxxxxxxx> wrote:
> BTW if you're worried about sysctl races you may also want to resurrect
> https://lkml.org/lkml/2009/12/20/214

Yeah, this had bothered me too while reading the code. The only "good"
news is that the strings are always NULL terminated and only "old"
contents can ever leak. Still, it's kind of horrible that there is no
locking here. :)

-Kees

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/