Re: [PATCH] radio-bcm2048.c: fix wrong overflow check

From: Pali RohÃr
Date: Tue Apr 22 2014 - 04:56:10 EST


On Tuesday 22 April 2014 10:39:17 Dan Carpenter wrote:
> On Sun, Apr 20, 2014 at 04:56:22PM +0200, Pavel Machek wrote:
> > Fix wrong overflow check in radio-bcm2048.
> >
> > Signed-off-by: Pali RohÃr <pali.rohar@xxxxxxxxx>
> > Signed-off-by: Pavel Machek <pavel@xxxxxx>
>
> Signed off means like you're signing a legal document to show
> that you didn't do anything illegal when you handled the
> patch. Was this patch authored by Pali? If so, then use the
> From: header.
>
> Btw, I reported this bug on Dec 10 last year. It's better
> that we fix it now than not fix it at all but we could have
> done better. Was the kbuild-zero-day bug report format
> confusing or how could I have helped out there?
>
> regards,
> dan carpenter

Hello, I sent this patch months ago, but not generated by
commmand git format-patch. And yes, this problem was reported by
some public static code checker.

--
Pali RohÃr
pali.rohar@xxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.