Re: [PATCH 1/1] fs/xfs/xfs_log.c: Fix comparison to bool

[Dave Chinner]

On Wed, Apr 16, 2014 at 03:15:57PM -0700, Andrew Morton wrote:
> On Sun, 13 Apr 2014 22:09:17 +0200 Fabian Frederick <fabf@xxxxxxxxx> wrote:
> 
> > Fixing coccinelle warning
> 
> Please always quote the full error message or warning text when fixing
> such things.

And CC the correct lists (xfs@xxxxxxxxxxx) and/or the subsystem
maintainer (me). LKML is extremely lossy - I got behind on reading
it and so simply deleted the 10,000 queued emails, one of which was
this patch....

> > --- a/fs/xfs/xfs_log.c
> > +++ b/fs/xfs/xfs_log.c
> > @@ -2376,7 +2376,7 @@ next_lv:
> >  				if (lv)
> >  					vecp = lv->lv_iovecp;
> >  			}
> > -			if (record_cnt == 0 && ordered == false) {
> > +			if (record_cnt == 0 && !ordered) {
> >  				if (!lv)
> >  					return 0;
> 
> There was nothing wrong with that code.  I suspect coccinelle bustage.

Agreed, especially given that the variable is declared as:

	bool ordered = false;

So it can only have the values of false and true....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/