Re: [PATCH] s390/ccwgroup: Fix memory corruption

From: Tejun Heo
Date: Wed Apr 23 2014 - 15:01:24 EST


On Wed, Apr 23, 2014 at 08:58:45PM +0200, Christian Borntraeger wrote:
> commit 0b60f9ead5d4816e7e3d6e28f4a0d22d4a1b2513 (s390: use
> device_remove_file_self() instead of device_schedule_callback())
>
> caused random memory corruption on my s390 box. Turns out that the
> last element of the ccwgroup structure is of dynamic size, so we
> must move the newly introduced work structure _before_ the zero
> length array.
>
> Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> CC: Tejun Heo <tj@xxxxxxxxxx>
> CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> CC: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> CC: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> CC: Sebastian Ott <sebott@xxxxxxxxxxxxxxxxxx>
> CC: Peter Oberparleiter <oberpar@xxxxxxxxxxxxxxxxxx>

Oops,

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/